Skip to content

core/txpool: add sanity overflow check #32544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

core/txpool: add sanity overflow check #32544

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab137ea
core/txpool: add sanity overflow check
MariusVanDerWijden Sep 4, 2025
239738b
core/txpool: apply diff
MariusVanDerWijden Sep 9, 2025
29e11ad
core/txpool/legacypool: fix bug
MariusVanDerWijden Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions core/txpool/legacypool/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,15 +323,22 @@ func (l *list) Add(tx *types.Transaction, priceBump uint64) (bool, *types.Transa
if tx.GasFeeCapIntCmp(thresholdFeeCap) < 0 || tx.GasTipCapIntCmp(thresholdTip) < 0 {
return false, nil
}
// Old is being replaced, subtract old cost
l.subTotalCost([]*types.Transaction{old})
}
// Add new tx cost to totalcost
cost, overflow := uint256.FromBig(tx.Cost())
if overflow {
return false, nil
}
l.totalcost.Add(l.totalcost, cost)
total, overflow := new(uint256.Int).AddOverflow(l.totalcost, cost)
if overflow {
return false, nil
}
l.totalcost = total

// Old is being replaced, subtract old cost
if old != nil {
l.subTotalCost([]*types.Transaction{old})
}

// Otherwise overwrite the old transaction with the current one
l.txs.Put(tx)
Expand Down