ethclient: ensure the close of canceled context #28349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
force-pushed
the
test-ensure-close-of-context
branch
from
8db5361 to
069da10
Compare
rjl493456442
approved these changes
Oct 17, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 789c18d.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…)" This reverts commit 789c18d.
Dergarcon
pushed a commit
to MetaMask/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case
TestEthClient/TxInBlockInterruptedchecks whether the interfaceeth_getTransactionByBlockHashAndIndexworks correctly with a canceled context. Therefore, it passes a cancelled context to the interface and expects aniltransaction is returned.However, as the close of the
Donechannel may happen asynchronously after the cancel function returns, this test case may occasionally return a non-nil transaction.This PR adds
<-ctx.Done()to ensure the close of theDonechannel.The test case has failed several times on free GitHub Actions CI runners.