core: replace instances of 'suicide' with 'selfdestruct' to improve code consistency. #27716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for code consistency. remove unecessary check for nil stateObject in statedb.SelfDestruct
holiman
approved these changes
Jul 13, 2023
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM, but I'd slightly lean towards keeping the nil-check
jwasinger
requested review from
MariusVanDerWijden,
gballet,
karalabe,
rjl493456442 and
s1na
as code owners
Co-authored-by: Martin Holst Swende <[email protected]>
holiman
approved these changes
Jul 13, 2023
lightclient
reviewed
Jul 13, 2023
Co-authored-by: lightclient <[email protected]>
Member
|
Looks like some tracer tests are still failing |
Contributor
|
somebody said tracer? |
s1na
reviewed
Jul 14, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…ode consistency. (ethereum#27716) --------- Co-authored-by: Martin Holst Swende <[email protected]> Co-authored-by: lightclient <[email protected]>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…mprove code consistency. (ethereum#27716)" This reverts commit 50cb341.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…mprove code consistency. (ethereum#27716)" This reverts commit 50cb341.
2 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 24, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 12, 2025
Merged
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 13, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Sep 9, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, it removes a check for
nilstateObjectreturn withinStateDB.SelfDestruct: the address is that of the currently-executing contract so the correspondingstateObjectis guaranteed to exist.