core: use slices package for sorting #27489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlaine
requested review from
holiman,
karalabe and
rjl493456442
as code owners
rjl493456442
approved these changes
Jun 19, 2023
Member
rjl493456442
left a comment
rjl493456442
left a comment
There was a problem hiding this comment.
a few nitpicks, otherwise lgtm
fjl
changed the title
fjl
force-pushed
the
use-slices-package-for-sorting-core
branch
from
803754b to
363b8d2
Compare
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
Co-authored-by: Felix Lange <[email protected]>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit d7a94d9.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit d7a94d9.
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Oct 30, 2025
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Oct 30, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Nov 13, 2025
19 tasks
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #27474