Skip to content

jsre: print BigNumber objects with custom constructor as number #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2016
Merged

jsre: print BigNumber objects with custom constructor as number #2448

merged 1 commit into from
Apr 12, 2016

Conversation

@fjl
Copy link
Contributor

@fjl fjl commented Apr 12, 2016 

go-ethereum >> ./build/bin/geth --verbosity=0 console
instance: Geth/v1.4.0-unstable-f460b021/darwin/go1.6
coinbase: 0x5e97870f263700f46aa00d967821199b9bc5a120
at block: 1323837 (Tue, 12 Apr 2016 17:40:08 CEST)
 datadir: /Users/fjl/Library/Ethereum
> eth.getBalance(eth.accounts[5])
70000000000000000000
> new BigNumber(1)
1

@robotally
Copy link

robotally commented Apr 12, 2016

Vote Count Reviewers
👍 1 @bas-vk
👎 0

Updated: Tue Apr 12 16:44:09 UTC 2016

@fjl fjl mentioned this pull request Apr 12, 2016
Closed
@codecov-io
Copy link

codecov-io commented Apr 12, 2016

Current coverage is 51.23%

Merging #2448 into develop will decrease coverage by -0.01% as of 2a7b7b6

Powered by Codecov. Updated on successful CI builds.

@fjl
Copy link
Contributor Author

fjl commented Apr 12, 2016

@bas-vk please review, it should fix the printing issue.

@fjl fjl added review and removed in progress labels Apr 12, 2016
@bas-vk
Copy link
Member

bas-vk commented Apr 12, 2016

👍

@fjl fjl merged commit 9d81f4f into ethereum:develop Apr 12, 2016
@fjl fjl removed the review label Apr 12, 2016
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request May 23, 2024
@NathanBSC @holiman
eth/filters: enforce topic-limit early on filter criterias (ethereum#…
b57c779 
…29535) (ethereum#2448)

This PR adds a limit of 1000 to the "inner" topics in a filter-criteria

Co-authored-by: Martin HS <[email protected]>
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request May 23, 2024
@NathanBSC @holiman @zzzckck
eth/filters: enforce topic-limit early on filter criterias (ethereum#…
adb5e8f 
…29535) (ethereum#2448)

This PR adds a limit of 1000 to the "inner" topics in a filter-criteria

Co-authored-by: Martin HS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fjl @robotally @codecov-io @bas-vk