internal/ethapi: fix incorrect type on empty slice #24372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0x6f736f646f <[email protected]>
s1na
reviewed
Feb 11, 2022
internal/ethapi/api.go
Outdated
| GasUsedRatio []float64 `json:"gasUsedRatio"` | ||
| } | ||
|
|
||
| // FeeHistory function |
Contributor
There was a problem hiding this comment.
Nice that you added a comment, but it's not a very helpful one
Contributor
There was a problem hiding this comment.
Please remove this or write something sensible
verheesj
approved these changes
Feb 13, 2022
tqpcharlie
approved these changes
Feb 13, 2022
holiman
approved these changes
Feb 15, 2022
Contributor
holiman
left a comment
holiman
left a comment
There was a problem hiding this comment.
LGTM aside from the stray comment
internal/ethapi/api.go
Outdated
| GasUsedRatio []float64 `json:"gasUsedRatio"` | ||
| } | ||
|
|
||
| // FeeHistory function |
Contributor
There was a problem hiding this comment.
Please remove this or write something sensible
holiman
reviewed
Feb 15, 2022
holiman
changed the title
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Feb 15, 2022
* Fixes ethereum#24368 Signed-off-by: 0x6f736f646f <[email protected]> * Update internal/ethapi/api.go Co-authored-by: Martin Holst Swende <[email protected]>
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
* Fixes ethereum#24368 Signed-off-by: 0x6f736f646f <[email protected]> * Update internal/ethapi/api.go Co-authored-by: Martin Holst Swende <[email protected]>
This was referenced Sep 23, 2022
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Sep 30, 2022
* Fixes ethereum#24368 Signed-off-by: 0x6f736f646f <[email protected]> * Update internal/ethapi/api.go Co-authored-by: Martin Holst Swende <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 0x6f736f646f [email protected]
Resolves #24368