newPendingTransactions support in ethclient.go

[huahuayu]

hi, for eth_subscribe method, I wonder why the client only supports newHeads

go-ethereum/ethclient/ethclient.go

Line 333 in 16bc574

func (ec *Client) SubscribeNewHead(ctx context.Context, ch chan<- *types.Header) (ethereum.Subscription, error) {

but don't supportnewPendingTransactions in ethclient.go

they are all be mentioned in the same place in the document: https://geth.ethereum.org/docs/rpc/pubsub

but if I want to subscribe newPendingTransactions I have to use underlaying rpc client. Since it's not exported, so I have to instantiation a *rpc.Client besides an *ethclient.Client

type Client struct {	c *rpc.Client}

[huahuayu]

another issue is newPendingTransactions only returns tx hash, I have to do another query to get tx data, is it possible to return verbose tx content when subscribe?

[huahuayu]

@fjl @karalabe how do you think?

[MariusVanDerWijden]

eth_subscribe is a non-standard api and should therefore not be in ethclient but rather in the gethclient. I think supporting newPendingTransactions in the gethclient would be okay. Do you want to move and implement it?

[fjl]

This is not entirely true. We do have support for eth_subscribe APIs in ethclient, just not for pending transactions.

[MariusVanDerWijden]

I know, but it should not be in ethclient imo as it is not part of the json-rpc api standard

[senthilsamrat]

https://geth.ethereum.org/docs/rpc/pubsub

can you post a sample code for subscribing to pending transaction. I am new to Go and Geth. Please it would help me a lot for my project. Thanks in advance!

[s1na]

Fixed via #25186. gethclient has now SubscribePendingTransactions and SubscribeFullPendingTransactions.