Skip to content

Conversation

@pauldowman
Copy link
Contributor

@pauldowman pauldowman commented Oct 3, 2025

Adds config and flags to op-program and op-challenger for op-node's --l1.beacon.skip-blob-verification.

@pauldowman pauldowman requested a review from mbaxter October 3, 2025 20:01
@pauldowman pauldowman changed the title Add op-program and op-challenger Add skip-blob-verification flag to op-program and op-challenger Oct 3, 2025
@pauldowman pauldowman marked this pull request as ready for review October 3, 2025 20:18
@pauldowman pauldowman requested review from a team as code owners October 3, 2025 20:18
@pauldowman pauldowman requested a review from geoknee October 3, 2025 20:18
Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just flagging a few other places where we may want to soften.

@pauldowman pauldowman force-pushed the pd/op-program-skip-blob-verification branch from a918186 to 11a71bd Compare October 3, 2025 20:29
Base automatically changed from gk/skip-blob-verification to develop October 3, 2025 20:56
@circleci-checks circleci-checks bot requested a review from a team as a code owner October 3, 2025 20:56
@pauldowman pauldowman force-pushed the pd/op-program-skip-blob-verification branch from 11a71bd to 86842d4 Compare October 3, 2025 21:10
@pauldowman
Copy link
Contributor Author

Rebased on develop now that #17713 is merged

Copy link
Contributor

@mbaxter mbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pauldowman pauldowman enabled auto-merge October 3, 2025 21:24
@pauldowman pauldowman added this pull request to the merge queue Oct 3, 2025
Merged via the queue into develop with commit 3ee883b Oct 3, 2025
67 checks passed
@pauldowman pauldowman deleted the pd/op-program-skip-blob-verification branch October 3, 2025 21:52
geoknee added a commit that referenced this pull request Oct 6, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 6, 2025
…17725)

* recompute blob proof if skipBlobVerification

* use even simpler verification

* replace verification logic

* refactor to make verification more direct

This approach does not use any additional data from the beacon endpoint, aside from the blob itself, so anticipates future API changes where this will be the only data provided.

* tweak comments

* rename to verifyBlob

* tweak test comments

* Revert "op-service/L1BeaconClient: allow blob proof verification to be skipped via `l1.beacon.skip-blob-verification` flag (#17713)"

This reverts commit 05ba528.

* Revert "Add `skip-blob-verification` flag to op-program and op-challenger  (#17718)"

This reverts commit 3ee883b.

* add an extra unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants