op-devstack: L2EL Engine API support for op-geth #17714
Merged
+218
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcw109550
changed the title
pcw109550
requested review from
nonsense and
serpixel
and removed request for
serpixel
pcw109550
commented
Oct 6, 2025
op-devstack/dsl/l2_el.go
Outdated
| return payload | ||
| } | ||
|
|
||
| func (el *L2ELNode) NewPayload(ref *L2ELNode, number uint64) *NewPayloadResult { |
There was a problem hiding this comment.
We are making the payload to insert from the reference EL node, in this case sequencer EL. After we fetch the payload, we insert it to the verifier EL using this method.
nonsense
reviewed
Oct 6, 2025
nonsense
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to validate L2EL behavior, since removing RR sync relies on EL behavior.
This PR exposes engine APIs at devstack, and make them usable at acceptance test, also adding DSL.
We can now directly control the L2EL by calling engine APIs at the tests. Before this PR, we indirectly test the L2EL using the L2CL, by modifying the L2CL. We may need a direct path to test the L2EL it self, by directly calling engine APIs to the L2EL.
Firstly tested for op-geth.
Tests
To validate basic engine API functionality, I added
TestVerifierManualSyncacceptance test. This turns off verifier EL's P2P and verifier CL, and manually callengine_newPayloadandengine_forkChoiceUpdatedto extend the canonical chain for verifier EL.Metadata
Part of #17694