-
Notifications
You must be signed in to change notification settings - Fork 266
relocate-custom-gas-tokens #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
relocate from management to features folder
WalkthroughThe changes involve updating features and links related to the "Run a Custom Gas Token Chain." This feature has been shifted from management to pre-installs in the JSON configuration for chain operators. Additionally, the link in the guide on deploying a custom gas token chain has been updated, and a URL path has been redirected to reflect these changes. Changes
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (4)
Files skipped from review due to trivial changes (3)
Additional context usedPath-based instructions (1)
LanguageTool
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (6)
pages/stack/protocol/features/custom-gas-token.mdx (6)
Line range hint
20-20
: Consider adding an article for clarity.- deposit ETH from L1 into the L2 chain as native L2 token + deposit ETH from L1 into the L2 chain as a native L2 token
Line range hint
48-48
: Add an article for grammatical correctness.- can use an L1 ERC-20 token as the custom gas token for L2 OP Stack chain deployment + can use an L1 ERC-20 token as the custom gas token for an L2 OP Stack chain deployment
Line range hint
49-49
: Correct the repeated word for clarity.- can use an ERC-20 token on an existing L2 OP Stack chain as as the custom gas token for an L3 OP Stack chain deployment + can use an ERC-20 token on an existing L2 OP Stack chain as the custom gas token for an L3 OP Stack chain deployment
Line range hint
83-83
: Consider using a less wordy expression.- does not have special logic for taking into account the exchange rate + does not account for the exchange rate
Line range hint
85-85
: Simplify the expression for brevity.- This would enable an on chain oracle to take into account the exchange rate of the custom gas token. + This would enable an on-chain oracle to consider the exchange rate of the custom gas token.
Line range hint
93-93
: Simplify the expression and correct the spelling.- is exactly the same as any other OP Stack based chain. + is the same as any other OP Stack-based chain.
relocate from management to features folder