fjord-notice #739
fjord-notice #739
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Warning Rate limit exceeded@cpengilly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 59 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent updates focus on revising the documentation and configuration files to accommodate the Fjord network upgrade. This involves updating network upgrade notices, fee estimation methods, adding support for new compression techniques, and adjusting versioning for protocol releases. Additionally, vocabulary updates and accepted status codes are also modified to align with the latest changes. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Stammler <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Outside diff range and nitpick comments (1)
pages/builders/node-operators/network-upgrades.mdx (1)
Line range hint
129-150: Simplify the phrase "prior to" for better readability.- * `Mainnet Upgrade Notice Period` is to allow mainnet node operators to upgrade the node software on mainnet prior to the activation timestamp. + * `Mainnet Upgrade Notice Period` allows mainnet node operators to upgrade the node software on mainnet before the activation timestamp.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (8)
pages/stack/protocol/fault-proofs/mips.mdx (8)
Line range hint
25-25: Consider adding a comma before "i.e." to enhance readability.- ...dispute game i.e. by a `FaultDisputeGame.sol` contract... + ...dispute game, i.e., by a `FaultDisputeGame.sol` contract...
Line range hint
38-38: Consider using a more concise alternative to "in order to."- ...in order to perform a single MIPS instruction onchain... + ...to perform a single MIPS instruction onchain... - ...In order to execute a MIPS instruction onchain, the... + ...To execute a MIPS instruction onchain, the... - ...in order to execute a single instruction onchain is... + ...to execute a single instruction onchain is... - ...In order to ensure the integrity of the entire address... + ...To ensure the integrity of the entire address... - ...in order to determine the true post state given a pre state... + ...to determine the true post state given a pre state...Also applies to: 51-51, 85-85, 87-87, 169-169
Line range hint
85-85: Remove redundancy in the phrase "The primary reason for this is because."- ...The primary reason for this is because having to load the entire memory... + ...The primary reason for this is that loading the entire memory...
Line range hint
87-87: Consider rephrasing "exactly the same" to a shorter form for conciseness.- ...This merkle root should be exactly the same as the merkle root stored... + ...This merkle root should match the merkle root stored...
Line range hint
119-119: Clarify the use of "the write syscall" and remove the redundant hyphen in "newly-derived."- ...the target of the write syscall, `handleSyscall` will not call... + ...the target of writing, `handleSyscall` will not call... - ...at the location of the newly-derived `preimageKey`. + ...at the location of the newly derived `preimageKey`.
Line range hint
154-154: Consider adding a comma for clarity and rephrase "in order to" for conciseness.- ...is 32-bytes so at most `readMem` will only read 4-bytes due to the... + ...is 32-bytes, so at most `readMem` will only read 4-bytes due to the... - ...The address is used as the path in order to determine the order for hashing... + ...The address is used as the path to determine the order for hashing...
Line range hint
169-169: Correct the compound word "pre state" to "prestate."- ...to determine the true post state given a pre state and... + ...to determine the true post state given a prestate and...
Line range hint
178-178: Adjust the use of "however" to improve sentence structure.- ...according to the MIPS specification, however other instructions... + ...according to the MIPS specification; however, other instructions...
Co-authored-by: soyboy <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
new fjord notice page with updates to node upgrade page