-
Notifications
You must be signed in to change notification settings - Fork 265
new protocol directory #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Warning Rate Limit Exceeded@cpengilly has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 27 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates in the documentation focus on refining hyperlinks to specific sections like rollups, smart contracts, and design principles. Metadata adjustments and redirects enhance navigation and clarity for users seeking detailed information within the OP Stack documentation. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (12)
pages/builders/chain-operators/self-hosted.mdx (1)
Line range hint
96-96
: Consider rephrasing "Adding a Precompile" for clarity.The term "Precompile" might be non-standard in this context. Consider rephrasing to "Adding Precompiled Contracts" for better clarity.
- [Adding a Precompile](tutorials/adding-precompiles) + [Adding Precompiled Contracts](tutorials/adding-precompiles)pages/builders/app-developers/bridging/messaging.mdx (8)
Line range hint
57-57
: Consider using a shorter alternative to "exact same".The phrase "exact same" might be wordy. Consider using "same" instead.
- they're doing the exact same thing. + they're doing the same thing.
Line range hint
89-89
: Consider using a stronger adverb.The phrase "completely different network" might be strengthened by using a different adverb.
- a completely different network. + an entirely different network.
Line range hint
131-131
: Consider using an en dash for the range.When specifying a range, consider using an en dash instead of a hyphen.
- take **approximately 1-3 minutes** + take **approximately 1–3 minutes**
Line range hint
153-153
: Avoid repetitive sentence beginnings.Three successive sentences begin with "This". Consider rewording for variety.
- This waiting period is a core part of the security model of the OP Stack and cannot be circumvented. + The waiting period is a core part of the security model of the OP Stack and cannot be circumvented.
Line range hint
160-160
: Consider a shorter alternative to avoid wordiness.The phrase "In order to get around this" might be wordy. Consider using "To address this".
- In order to get around this, you can find a `xDomainMessageSender` function + To address this, you can find a `xDomainMessageSender` function
Line range hint
161-161
: Use the correct preposition.The preposition “for” seems more appropriate than “to” in this context.
- function to each messenger: + function for each messenger:
Line range hint
205-205
: Ensure the article "the" is included.You might be missing the article “the” here.
- after L2 block, including your L2 transaction, + after the L2 block, including your L2 transaction,
Line range hint
231-231
: Include a comma after "Otherwise".A comma may be missing after the conjunctive/linking adverb ‘Otherwise’.
- Otherwise you might be making decisions based on an invalid transaction result. + Otherwise, you might be making decisions based on an invalid transaction result.pages/builders/chain-operators/tutorials/create-l2-rollup.mdx (3)
Line range hint
125-125
: Use "an" before nouns that start with a vowel sound.- You'll be deploying a OP Stack Rollup chain that uses a Layer 1 blockchain to host and order transaction data. + You'll be deploying an OP Stack Rollup chain that uses a Layer 1 blockchain to host and order transaction data.
Line range hint
319-319
: Add a comma for clarity.- You do not need to send any ETH to the `Sequencer` address as it does not send transactions. + You do not need to send any ETH to the `Sequencer` address, as it does not send transactions.
Line range hint
625-625
: Add a comma for clarity.- Once you've got `op-geth` running you'll need to run `op-node`. + Once you've got `op-geth` running, you'll need to run `op-node`.
@sbvegan i think we can still merge since the link issues are with outside links (not internal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit of a nit, but the OP Stack is a singular rollup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (61)
words.txt (61)
Line range hint
1-2
: Remove duplicate entries forACCOUNTQUEUE
andaccountqueue
.- ACCOUNTQUEUE - accountqueue + ACCOUNTQUEUE + accountqueue
Line range hint
19-22
: Remove duplicate entries forBLOCKLOGS
andblocklogs
.- BLOCKLOGS - blocklogs + BLOCKLOGS + blocklogs
Line range hint
24-27
: Remove duplicate entries forBLOCKPROFILERATE
andblockprofilerate
.- BLOCKPROFILERATE - blockprofilerate + BLOCKPROFILERATE + blockprofilerate
Line range hint
32-36
: Remove duplicate entries forBootnodes
andbootnodes
.- Bootnodes - bootnodes + Bootnodes + bootnodes
Line range hint
40-47
: Remove duplicate entries forChainlink
andchainlist
.- Chainlink - chainlist + Chainlink + chainlist
Line range hint
53-55
: Remove duplicate entries forDATADIR
anddatadir
.- DATADIR - datadir + DATADIR + datadir
Line range hint
59-63
: Remove duplicate entries forDevnet
anddevnet
.- Devnet - devnet + Devnet + devnet
Line range hint
65-68
: Remove duplicate entries forDISABLETXPOOLGOSSIP
anddisabletxpoolgossip
.- DISABLETXPOOLGOSSIP - disabletxpoolgossip + DISABLETXPOOLGOSSIP + disabletxpoolgossip
Line range hint
70-72
: Remove duplicate entries forETHERBASE
andetherbase
.- ETHERBASE - etherbase + ETHERBASE + etherbase
Line range hint
74-76
: Remove duplicate entries forETHSTATS
andethstats
.- ETHSTATS - ethstats + ETHSTATS + ethstats
Line range hint
78-80
: Remove duplicate entries forEVMTIMEOUT
andevmtimeout
.- EVMTIMEOUT - evmtimeout + EVMTIMEOUT + evmtimeout
Line range hint
84-92
: Remove duplicate entries forGLOBALQUEUE
andglobalqueue
.- GLOBALQUEUE - globalqueue + GLOBALQUEUE + globalqueue
Line range hint
95-98
: Remove duplicate entries forGLOBALSLOTS
andglobalslots
.- GLOBALSLOTS - globalslots + GLOBALSLOTS + globalslots
Line range hint
100-106
: Remove duplicate entries forHEALTHCHECK
andhealthcheck
.- HEALTHCHECK - healthcheck + HEALTHCHECK + healthcheck
Line range hint
109-111
: Remove duplicate entries forHISTORICALRPC
andhistoricalrpc
.- HISTORICALRPC - historicalrpc + HISTORICALRPC + historicalrpc
Line range hint
113-116
: Remove duplicate entries forHISTORICALRPCTIMEOUT
andhistoricalrpctimeout
.- HISTORICALRPCTIMEOUT - historicalrpctimeout + HISTORICALRPCTIMEOUT + historicalrpctimeout
Line range hint
119-121
: Remove duplicate entries forINFLUXDBV
andinfluxdbv
.- INFLUXDBV - influxdbv + INFLUXDBV + influxdbv
Line range hint
124-127
: Remove duplicate entries forIPCPATH
andipcpath
.- IPCPATH - ipcpath + IPCPATH + ipcpath
Line range hint
140-142
: Remove duplicate entries forMAXAGE
andmaxage
.- MAXAGE - maxage + MAXAGE + maxage
Line range hint
144-146
: Remove duplicate entries forMAXBACKUPS
andmaxbackups
.- MAXBACKUPS - maxbackups + MAXBACKUPS + maxbackups
Line range hint
148-151
: Remove duplicate entries forMAXPEERS
andmaxpeers
.- MAXPEERS - maxpeers + MAXPEERS + maxpeers
Line range hint
153-157
: Remove duplicate entries forMAXPENDPEERS
andmaxpendpeers
.- MAXPENDPEERS - maxpendpeers + MAXPENDPEERS + maxpendpeers
Line range hint
159-175
: Remove duplicate entries forMINFREEDISK
andminfreedisk
.- MINFREEDISK - minfreedisk + MINFREEDISK + minfreedisk
Line range hint
177-179
: Remove duplicate entries forMINSUGGESTEDPRIORITYFEE
andminsuggestedpriorityfee
.- MINSUGGESTEDPRIORITYFEE - minsuggestedpriorityfee + MINSUGGESTEDPRIORITYFEE + minsuggestedpriorityfee
Line range hint
182-184
: Remove duplicate entries forNETWORKID
andnetworkid
.- NETWORKID - networkid + NETWORKID + networkid
Line range hint
186-189
: Remove duplicate entries forNEWPAYLOAD
andnewpayload
.- NEWPAYLOAD - newpayload + NEWPAYLOAD + newpayload
Line range hint
191-193
: Remove duplicate entries forNOCOMPACTION
andnocompaction
.- NOCOMPACTION - nocompaction + NOCOMPACTION + nocompaction
Line range hint
195-197
: Remove duplicate entries forNODEKEY
andnodekey
.- NODEKEY - nodekey + NODEKEY + nodekey
Line range hint
200-207
: Remove duplicate entries forNODEKEYHEX
andnodekeyhex
.- NODEKEYHEX - nodekeyhex + NODEKEYHEX + nodekeyhex
Line range hint
210-212
: Remove duplicate entries forNODISCOVER
andnodiscover
.- NODISCOVER - nodiscover + NODISCOVER + nodiscover
Line range hint
220-224
: Remove duplicate entries forNOLOCALS
andnolocals
.- NOLOCALS - nolocals + NOLOCALS + nolocals
Line range hint
228-230
: Remove duplicate entries forNOPREFETCH
andnoprefetch
.- NOPREFETCH - noprefetch + NOPREFETCH + noprefetch
Line range hint
233-235
: Remove duplicate entries forNOPRUNING
andnopruning
.- NOPRUNING - nopruning + NOPRUNING + nopruning
Line range hint
242-246
: Remove duplicate entries forNOSYNCSERVE
andnosyncserve
.- NOSYNCSERVE - nosyncserve + NOSYNCSERVE + nosyncserve
Line range hint
248-250
: Remove duplicate entries forOffchain
andoffchain
.- Offchain - offchain + Offchain + offchain
Line range hint
262-278
: Remove duplicate entries forpeerstores
andPermissioned
.- peerstores - Permissioned + peerstores + Permissioned
Line range hint
283-285
: Remove duplicate entries forpermissioned
andPermissionless
.- permissioned - Permissionless + permissioned + Permissionless
Line range hint
288-290
: Remove duplicate entries forpermissionless
andpermissionlessly
.- permissionless - permissionlessly + permissionless + permissionlessly
Line range hint
300-305
: Remove duplicate entries forpreconfigured
andpredeploy
.- preconfigured - predeploy + preconfigured + predeploy
Line range hint
308-310
: Remove duplicate entries forPredeployed
andpredeployed
.- Predeployed - predeployed + Predeployed + predeployed
Line range hint
312-314
: Remove duplicate entries forpredeploys
andPreimage
.- predeploys - Preimage + predeploys + Preimage
Line range hint
321-321
: Remove duplicate entries forPREIMAGES
andpreimages
.- PREIMAGES - preimages + PREIMAGES + preimages
Line range hint
1-321
: Remove duplicate entries forPreinstalls
andpreinstalls
.- Preinstalls - preinstalls + Preinstalls + preinstalls
Line range hint
1-321
: Remove duplicate entries forprestate
andPRICEBUMP
.- prestate - PRICEBUMP + prestate + PRICEBUMP
Line range hint
1-321
: Remove duplicate entries forpricebump
andPRICELIMIT
.- pricebump - PRICELIMIT + pricebump + PRICELIMIT
Line range hint
1-321
: Remove duplicate entries forpricelimit
andproductionize
.- pricelimit - productionize + pricelimit + productionize
Line range hint
1-321
: Remove duplicate entries forproductionized
andProtip
.- productionized - Protip + productionized + Protip
Line range hint
1-321
: Remove duplicate entries forproxyd
andpseudorandomly
.- proxyd - pseudorandomly + proxyd + pseudorandomly
Line range hint
1-321
: Remove duplicate entries forQuicknode
andquicknode
.- Quicknode - quicknode + Quicknode + quicknode
Line range hint
1-321
: Remove duplicate entries forquickstarts
andRANDAO
.- quickstarts - RANDAO + quickstarts + RANDAO
Line range hint
1-321
: Remove duplicate entries forRegenesis
andregenesis
.- Regenesis - regenesis + Regenesis + regenesis
Line range hint
1-321
: Remove duplicate entries forREJOURNAL
andrejournal
.- REJOURNAL - rejournal + REJOURNAL + rejournal
Line range hint
1-321
: Remove duplicate entries forREMOTEDB
andremotedb
.- REMOTEDB - remotedb + REMOTEDB + remotedb
Line range hint
1-321
: Remove duplicate entries forreplayability
andREQUIREDBLOCKS
.- replayability - REQUIREDBLOCKS + replayability + REQUIREDBLOCKS
Line range hint
1-321
: Remove duplicate entries forrequiredblocks
andRollups
.- requiredbocks - Rollups + requiredbocks + Rollups
Line range hint
1-321
: Remove duplicate entries forrpckind
andRPCPREFIX
.- rpckind - RPCPREFIX + rpckind + RPCPREFIX
Line range hint
1-321
: Remove duplicate entries forrpcprefix
andRPGF
.- rpcprefix - RPGF + rpcprefix + RPGF
Line range hint
1-321
: Remove duplicate entries forSELFDESTRUCT
andseqnr
.- SELFDESTRUCT - seqnr + SELFDESTRUCT + seqnr
Line range hint
1-321
: Remove duplicate entries forSEQUENCERHTTP
andsequencerhttp
.- SEQUENCERHTTP - sequencerhttp + SEQUENCERHTTP + sequencerhttp
Line range hint
1-321
: Remove duplicate entries forShapella
andsignup
.- Shapella - signup + Shapella + signup
Line range hint
1-321
: Remove duplicate entries forSLLV
andSLTI
.- SLLV - SLTI + SLLV + SLTI
create new
rollups
folder, update links