-
Notifications
You must be signed in to change notification settings - Fork 266
remove base from u16 #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove base from u16 #1695
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe changes remove the chain named Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/notices/upgrade-16.mdx (1)
49-49
: Remove stray space inside the inline code fence.There’s an extra trailing space after
Metal
which ends up inside the back-ticks and renders as “Metal ”.
This is visible in MD render and is inconsistent with the earlier list.- ... `Mode`, `Zora`, `Arena Z`, `Swell`, `World Chain`, and `Metal ` + ... `Mode`, `Zora`, `Arena Z`, `Swell`, `World Chain`, and `Metal`
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pages/notices/upgrade-16.mdx
(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.mdx
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧠 Learnings (2)
📓 Common learnings
Learnt from: qbzzt
PR: ethereum-optimism/docs#1216
File: pages/stack/interop/security.mdx:136-144
Timestamp: 2025-01-08T11:04:45.361Z
Learning: In the ethereum-optimism/docs repository, sections that are commented out in documentation files are intentionally excluded due to accuracy concerns and should not be suggested for inclusion until the information becomes accurate.
Learnt from: qbzzt
PR: ethereum-optimism/docs#1525
File: pages/stack/interop/tutorials/upgrade-to-superchain-erc20.mdx:500-503
Timestamp: 2025-04-03T01:38:08.988Z
Learning: Private keys in the "Upgrading ERC20 to SuperchainERC20" tutorial document are test/demo keys intentionally included for educational purposes and do not represent security concerns.
Learnt from: sbvegan
PR: ethereum-optimism/docs#536
File: pages/stack/protocol/smart-contracts.mdx:272-272
Timestamp: 2024-06-10T19:38:04.907Z
Learning: The ProtocolVersions release does not have a governance post because it is an optional feature.
Learnt from: sbvegan
PR: ethereum-optimism/docs#536
File: pages/stack/protocol/smart-contracts.mdx:272-272
Timestamp: 2024-10-08T15:32:06.348Z
Learning: The ProtocolVersions release does not have a governance post because it is an optional feature.
pages/notices/upgrade-16.mdx (2)
Learnt from: sbvegan
PR: ethereum-optimism/docs#1001
File: pages/builders.mdx:11-12
Timestamp: 2024-10-22T02:58:02.175Z
Learning: Prefer using 'OP Stack' over 'OP Mainnet' in documentation for consistency.
Learnt from: qbzzt
PR: ethereum-optimism/docs#1613
File: public/tutorials/attest.mjs:64-71
Timestamp: 2025-05-24T18:24:46.628Z
Learning: For tutorial and educational code in the ethereum-optimism/docs repository, prioritize simplicity and clarity over production-level robustness. Hardcoded values and simplified error handling are acceptable when they help demonstrate core concepts without unnecessary complexity.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (2)
pages/notices/upgrade-16.mdx (2)
64-67
: Looks good—list is internally consistent.
Base
is no longer present, comma placement is correct, and the Oxford comma is preserved.
24-26
: No lingeringBase
references found in Upgrade-16 docs.A global case-insensitive search for “Base” within all
*.mdx
files mentioning “Upgrade 16” returned no results—no further updates are needed.
Removes Base references