-
Notifications
You must be signed in to change notification settings - Fork 265
U15: New absolute prestate and op-challenger #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis set of changes updates documentation and a word list across three files. In Sequence Diagram(s)sequenceDiagram
participant User
participant Documentation
participant Node Operator
User->>Documentation: Reads Superchain withdrawal pause test notice
Documentation-->>User: Informs test completed on Apr 14, 2025
User->>Documentation: Reads Isthmus upgrade notice
Documentation-->>User: Provides Mainnet activation timestamp and updated instructions
Node Operator->>Documentation: Checks upgrade instructions
Documentation-->>Node Operator: Informs about op-challenger v1.4.0 and op-program v1.6.0-2
Documentation-->>Node Operator: Displays callout about Mainnet node binaries availability
Possibly related PRs
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pages/notices/upgrade-15.mdx (1)
20-143
: Minor grammar: Consider pluralizing "prestate" where appropriate.In several places, "prestate" is used as a plural noun (e.g., "absolute prestates"). The correct plural form should be "prestates." For example, in line 49: "deploy new dispute game contracts with new absolute prestates" and in line 55: "the 64 bit multi-threaded version of cannon is utilized" (contextually, this is fine, but check for consistency).
Consider updating "prestate" to "prestates" where referring to multiple instances for grammatical correctness.
Otherwise, the documentation is clear, uses proper nouns, imperative form, and avoids personal pronouns. Headers follow sentence case and proper noun capitalization. Technical instructions are accurate and up to date.
🧰 Tools
🪛 LanguageTool
[grammar] ~62-~62: The verb ‘prestate’ is plural. Did you mean: “prestates”? Did you use a verb instead of a noun?
Context: ...oneium) You can verify this absolute prestate by running the following [command](http...(PLURAL_VERB_AFTER_THIS)
[style] ~95-~95: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...e and validate that the expected output prior to executing the transaction. Th...(EN_WORDINESS_PREMIUM_PRIOR_TO)
[duplication] ~115-~115: Possible typo: you repeated a word.
Context: ... has been determined. *op-node
atv1.13.0
* [op-geth
atv1.101503.2
](https://github.com/ether...(ENGLISH_WORD_REPEAT_RULE)
[style] ~133-~133: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...othop-node
andop-geth
. These will need to be set onop-node
andop-geth
for t...(REP_NEED_TO_VB)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
pages/notices/superchain-withdrawal-pause-test.mdx
(1 hunks)pages/notices/upgrade-15.mdx
(4 hunks)words.txt
(0 hunks)
💤 Files with no reviewable changes (1)
- words.txt
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with the following criteria: - First, check the frontmatter section at the top of the file: 1. For regular pages, ensure AL...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- First, check the frontmatter section at the top of the file:
- For regular pages, ensure ALL these fields are present and not empty:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] personas: [non-empty array] categories: [non-empty array] content_type: [valid type] ---
- For landing pages (index.mdx or files with ), only these fields are required:
--- title: [non-empty] lang: [non-empty] description: [non-empty] topic: [non-empty] ---
- If any required fields are missing or empty, comment:
'This file appears to be missing required metadata. Please check keywords.config.yaml for valid options and add the required fields manually. You can validate your changes by running:pnpm validate-metadata ```'
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/notices/superchain-withdrawal-pause-test.mdx
pages/notices/upgrade-15.mdx
🪛 LanguageTool
pages/notices/upgrade-15.mdx
[grammar] ~62-~62: The verb ‘prestate’ is plural. Did you mean: “prestates”? Did you use a verb instead of a noun?
Context: ...oneium) You can verify this absolute prestate by running the following [command](http...
(PLURAL_VERB_AFTER_THIS)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
🔇 Additional comments (3)
pages/notices/upgrade-15.mdx (1)
1-16
: Frontmatter is complete and valid.All required metadata fields are present and non-empty. No action needed.
pages/notices/superchain-withdrawal-pause-test.mdx (2)
1-16
: Frontmatter is complete and valid.All required metadata fields are present and non-empty. No action needed.
23-24
: Update is clear and accurate.The callout correctly reflects the completion of the Sepolia Superchain withdrawal pause test. No issues found.
Description
Updating the new absolute prestate and op-challenger that must be used for U15. The new op-challenger release hasn't been published yet, so I'm still waiting on that