Skip to content

Conversation

cpengilly
Copy link
Contributor

fix links
update redirects

@cpengilly cpengilly requested a review from a team as a code owner February 12, 2025 09:32
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 1f5a347
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67ac723d62ceef0008920c1a
😎 Deploy Preview https://deploy-preview-1354--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Feb 12, 2025

📝 Walkthrough

Walkthrough

The pull request includes a series of documentation updates and minor configuration changes. A new entry for the local Netlify folder has been added to the .gitignore file. Several MDX documentation files have been updated to improve link clarity and consistency; many relative paths have been converted to absolute paths to ensure correct referencing regardless of context. Specific modifications include updates to tutorial links, the addition of a new self-hosted tutorial ("Creating Your Own L2 Rollup"), and the removal of an outdated one ("Using the OP Stack Client SDK"). Additionally, a new explanatory section was added in the Cannon Fault Proof documentation to clarify the differences between offchain and onchain processing in the fault proof virtual machine. Lastly, the _redirects file underwent extensive reorganization by altering and consolidating redirect paths across the site.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant S as Web Server
    participant R as _redirects Rules
    U->>S: Request URL (e.g., /builders/tools/xyz)
    S->>R: Look up redirect rule
    R-->>S: Return new URL (e.g., /app-developers/tools/xyz)
    S->>U: Redirects to new URL
Loading

Suggested labels

flag:merge-pending-release, tutorial

Suggested reviewers

  • bradleycamacho

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1026317 and 1f5a347.

📒 Files selected for processing (1)
  • pages/stack/interop/cross-chain/event-reads.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • pages/stack/interop/cross-chain/event-reads.mdx
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
pages/stack/fault-proofs/cannon.mdx (1)

193-193: Enhance clarity by specifying the type of witness data.

Consider revising to be more specific about what witness data includes (e.g., memory proofs, state information).

-Consequently, the witness data is essential to reproduce the same instruction onchain and offchain.
+Consequently, the witness data (including memory proofs, register state, and instruction data) is essential to reproduce the same instruction onchain and offchain.
pages/stack/dev-node.mdx (1)

178-179: Update header to use sentence case

Change the header to follow sentence case guidelines:

-## See Your Rollup in Action
+## See your rollup in action
public/_redirects (1)

128-134: Consider adding expiration dates for temporary GitHub redirects.

The historical notices section contains temporary GitHub redirects. It would be helpful to add expiration dates or a timeline for when these temporary redirects will be removed or updated.

 # ----------------------------------------------------------------------------
-# Historical Notices (Temporary GitHub redirects)
+# Historical Notices (Temporary GitHub redirects - Valid until March 2025)
 # ----------------------------------------------------------------------------
pages/app-developers/get-started.mdx (1)

24-24: Consider providing temporary alternatives for block explorers.

While the block explorers are TBD, consider providing temporary alternatives or instructions for users to view transactions during development.

-| <ul><li>RPC Endpoint: `local RPC URL` </li><li>Chain ID: `local chain ID`</li><li>Block explorer: TBD</li></ul> | <ul><li>RPC Endpoint: `devnet RPC URL`</li><li>Chain ID: `devnet chain ID`</li><li> Block explorer: TBD</li></ul> |
+| <ul><li>RPC Endpoint: `local RPC URL` </li><li>Chain ID: `local chain ID`</li><li>Block explorer: TBD (Use `eth_getTransactionReceipt` RPC method for transaction details)</li></ul> | <ul><li>RPC Endpoint: `devnet RPC URL`</li><li>Chain ID: `devnet chain ID`</li><li>Block explorer: TBD (Use `eth_getTransactionReceipt` RPC method for transaction details)</li></ul> |
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eecb846 and 1026317.

📒 Files selected for processing (14)
  • .gitignore (1 hunks)
  • pages/app-developers/building-apps.mdx (1 hunks)
  • pages/app-developers/get-started.mdx (1 hunks)
  • pages/app-developers/tutorials/transactions/sdk-trace-txns.mdx (2 hunks)
  • pages/operators/chain-operators/features/alt-da-mode.mdx (1 hunks)
  • pages/operators/chain-operators/self-hosted.mdx (0 hunks)
  • pages/stack/dev-node.mdx (1 hunks)
  • pages/stack/fault-proofs/cannon.mdx (1 hunks)
  • pages/stack/getting-started.mdx (1 hunks)
  • pages/stack/interop/superchain-weth.mdx (1 hunks)
  • pages/stack/interop/tutorials/relay-messages-cast.mdx (1 hunks)
  • pages/stack/smart-contracts.mdx (2 hunks)
  • pages/superchain/privileged-roles.mdx (1 hunks)
  • public/_redirects (1 hunks)
💤 Files with no reviewable changes (1)
  • pages/operators/chain-operators/self-hosted.mdx
✅ Files skipped from review due to trivial changes (8)
  • .gitignore
  • pages/superchain/privileged-roles.mdx
  • pages/app-developers/building-apps.mdx
  • pages/operators/chain-operators/features/alt-da-mode.mdx
  • pages/stack/interop/superchain-weth.mdx
  • pages/stack/smart-contracts.mdx
  • pages/stack/getting-started.mdx
  • pages/stack/interop/tutorials/relay-messages-cast.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...

**/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
  • pages/stack/dev-node.mdx
  • pages/stack/fault-proofs/cannon.mdx
  • pages/app-developers/get-started.mdx
  • pages/app-developers/tutorials/transactions/sdk-trace-txns.mdx
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules - docs-optimism
  • GitHub Check: Header rules - docs-optimism
  • GitHub Check: Pages changed - docs-optimism
  • GitHub Check: pr-workflow
🔇 Additional comments (3)
pages/stack/dev-node.mdx (1)

186-186: LGTM! Link path improvement

The change from relative to absolute path improves link reliability and maintainability.

public/_redirects (1)

4-8: Well-organized redirect structure with clear sections!

The file is well-organized with clear section headers and logical grouping of redirects.

pages/app-developers/tutorials/transactions/sdk-trace-txns.mdx (1)

11-11: Good use of absolute paths for improved link reliability!

Converting relative paths to absolute paths improves link reliability and makes the documentation more maintainable.

Also applies to: 161-161

@krofax krofax merged commit e3b3f06 into main Feb 12, 2025
8 checks passed
@krofax krofax deleted the big_fix_links branch February 12, 2025 10:07
@coderabbitai coderabbitai bot mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants