-
Notifications
You must be signed in to change notification settings - Fork 267
fix broken links #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken links #1354
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request includes a series of documentation updates and minor configuration changes. A new entry for the local Netlify folder has been added to the Sequence Diagram(s)sequenceDiagram
participant U as User
participant S as Web Server
participant R as _redirects Rules
U->>S: Request URL (e.g., /builders/tools/xyz)
S->>R: Look up redirect rule
R-->>S: Return new URL (e.g., /app-developers/tools/xyz)
S->>U: Redirects to new URL
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
pages/stack/fault-proofs/cannon.mdx (1)
193-193
: Enhance clarity by specifying the type of witness data.Consider revising to be more specific about what witness data includes (e.g., memory proofs, state information).
-Consequently, the witness data is essential to reproduce the same instruction onchain and offchain. +Consequently, the witness data (including memory proofs, register state, and instruction data) is essential to reproduce the same instruction onchain and offchain.pages/stack/dev-node.mdx (1)
178-179
: Update header to use sentence caseChange the header to follow sentence case guidelines:
-## See Your Rollup in Action +## See your rollup in actionpublic/_redirects (1)
128-134
: Consider adding expiration dates for temporary GitHub redirects.The historical notices section contains temporary GitHub redirects. It would be helpful to add expiration dates or a timeline for when these temporary redirects will be removed or updated.
# ---------------------------------------------------------------------------- -# Historical Notices (Temporary GitHub redirects) +# Historical Notices (Temporary GitHub redirects - Valid until March 2025) # ----------------------------------------------------------------------------pages/app-developers/get-started.mdx (1)
24-24
: Consider providing temporary alternatives for block explorers.While the block explorers are TBD, consider providing temporary alternatives or instructions for users to view transactions during development.
-| <ul><li>RPC Endpoint: `local RPC URL` </li><li>Chain ID: `local chain ID`</li><li>Block explorer: TBD</li></ul> | <ul><li>RPC Endpoint: `devnet RPC URL`</li><li>Chain ID: `devnet chain ID`</li><li> Block explorer: TBD</li></ul> | +| <ul><li>RPC Endpoint: `local RPC URL` </li><li>Chain ID: `local chain ID`</li><li>Block explorer: TBD (Use `eth_getTransactionReceipt` RPC method for transaction details)</li></ul> | <ul><li>RPC Endpoint: `devnet RPC URL`</li><li>Chain ID: `devnet chain ID`</li><li>Block explorer: TBD (Use `eth_getTransactionReceipt` RPC method for transaction details)</li></ul> |
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
.gitignore
(1 hunks)pages/app-developers/building-apps.mdx
(1 hunks)pages/app-developers/get-started.mdx
(1 hunks)pages/app-developers/tutorials/transactions/sdk-trace-txns.mdx
(2 hunks)pages/operators/chain-operators/features/alt-da-mode.mdx
(1 hunks)pages/operators/chain-operators/self-hosted.mdx
(0 hunks)pages/stack/dev-node.mdx
(1 hunks)pages/stack/fault-proofs/cannon.mdx
(1 hunks)pages/stack/getting-started.mdx
(1 hunks)pages/stack/interop/superchain-weth.mdx
(1 hunks)pages/stack/interop/tutorials/relay-messages-cast.mdx
(1 hunks)pages/stack/smart-contracts.mdx
(2 hunks)pages/superchain/privileged-roles.mdx
(1 hunks)public/_redirects
(1 hunks)
💤 Files with no reviewable changes (1)
- pages/operators/chain-operators/self-hosted.mdx
✅ Files skipped from review due to trivial changes (8)
- .gitignore
- pages/superchain/privileged-roles.mdx
- pages/app-developers/building-apps.mdx
- pages/operators/chain-operators/features/alt-da-mode.mdx
- pages/stack/interop/superchain-weth.mdx
- pages/stack/smart-contracts.mdx
- pages/stack/getting-started.mdx
- pages/stack/interop/tutorials/relay-messages-cast.mdx
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.mdx`: "ALWAYS review Markdown content THOROUGHLY with ...
**/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/stack/dev-node.mdx
pages/stack/fault-proofs/cannon.mdx
pages/app-developers/get-started.mdx
pages/app-developers/tutorials/transactions/sdk-trace-txns.mdx
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (3)
pages/stack/dev-node.mdx (1)
186-186
: LGTM! Link path improvementThe change from relative to absolute path improves link reliability and maintainability.
public/_redirects (1)
4-8
: Well-organized redirect structure with clear sections!The file is well-organized with clear section headers and logical grouping of redirects.
pages/app-developers/tutorials/transactions/sdk-trace-txns.mdx (1)
11-11
: Good use of absolute paths for improved link reliability!Converting relative paths to absolute paths improves link reliability and makes the documentation more maintainable.
Also applies to: 161-161
fix links
update redirects