Add new footer and custom styling #1232
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces changes to the website's footer visibility and content. In the Possibly Related PRs
Suggested Reviewers
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
theme.config.tsx (1)
69-72: Remove unnecessary empty lines.These consecutive empty lines don't serve any purpose and should be removed for better code cleanliness.
footer: { text: (...), }, - - - - sidebar: {
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
styles/global.css(0 hunks)theme.config.tsx(1 hunks)
💤 Files with no reviewable changes (1)
- styles/global.css
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
theme.config.tsx (1)
57-57: Use dynamic year for copyright notice.Instead of hardcoding the year, consider using
new Date().getFullYear()to automatically keep the copyright year current.- <div>© 2025 Optimism Foundation. All rights reserved.</div> + <div>© {new Date().getFullYear()} Optimism Foundation. All rights reserved.</div>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
next-env.d.ts(1 hunks)theme.config.tsx(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- next-env.d.ts
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (2)
theme.config.tsx (2)
48-56: Consider moving inline styles to a CSS module.The inline styles make the code harder to maintain. A previous review already suggested moving these styles to a CSS module.
59-69: Improve link accessibility.The links lack hover states and focus indicators, which are important for accessibility. A previous review already suggested these improvements.
Adds a new footer containing compliance links. This adds custom styling for the future too in case we want to alter it, but I can't seem to figure out how to make the total footer height smaller than it's current height.