-
Notifications
You must be signed in to change notification settings - Fork 267
Added token house grants #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added token house grants #1228
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThis pull request introduces modifications to two files: In the Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pages/chain/identity/schemas.mdx (1)
101-120
: LGTM! Well-structured schema for token house grants.The new schema section is well-documented and follows the established pattern. The explicit date format specification and clear field descriptions enhance maintainability.
Consider adding descriptions for the currently null fields (refUID and MetadataUrl) to indicate their intended future use.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pages/chain/identity/schemas.mdx
(5 hunks)words.txt
(6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/chain/identity/schemas.mdx (1)
Pattern **/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
🪛 LanguageTool
pages/chain/identity/schemas.mdx
[grammar] ~42-~42: The singular determiner ‘this’ may not agree with the plural noun ‘organizations’. Did you mean “these”?
Context: ...| parentOrgUID | The attestation UID of this organizations's parent, in case it has ...
(THIS_NNS)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-optimism
- GitHub Check: Header rules - docs-optimism
- GitHub Check: Pages changed - docs-optimism
- GitHub Check: pr-workflow
🔇 Additional comments (2)
words.txt (1)
13-13
: LGTM! New terms added correctly.The new terms have been added in alphabetical order and maintain the existing pattern of including both uppercase and proper case variations where applicable.
Also applies to: 154-154, 203-203, 301-302, 337-339, 413-413
pages/chain/identity/schemas.mdx (1)
18-18
: LGTM! Consistent heading capitalization.The changes to heading capitalization align with the coding guidelines for sentence case in headers while preserving proper nouns.
Also applies to: 144-144, 158-158
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge, the coderabbit nit seems fine to add if you want. We should talk to Emily about the current identity item we have planned for this sprint
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
Added token house grants from Emily
Tests
Additional context
Metadata