refactor: replace WokwiCLI with Wokwi class (RDT-1428) #365
Conversation
pytest-embedded-wokwi/pyproject.toml
Outdated
| @@ -34,6 +35,8 @@ requires-python = ">=3.7" | |||
| dependencies = [ | |||
| "pytest-embedded~=1.17.0a2", | |||
| "toml~=0.10.2", | |||
| # Temporary workaround for Wokwi client - will be redirected to the official repo | |||
There was a problem hiding this comment.
I am still waiting for wokwi-client PR release - wokwi/wokwi-python-client#2
|
But the rest code seems to be working |
github-actions
bot
changed the title
|
this looks like a huge improvement! could close #233 as well |
|
I have looked at the tests, and they have not worked successfully for a long time. Can I do something to fix them, or do they need bigger changes? |
|
@JakubAndrysek you don't need to worry about the test cases. the wokwi test cases are not running anyway. seems like the runner is failing... I'll take care of those. |
pytest-embedded-wokwi/pyproject.toml
Outdated
| # Temporary workaround for Wokwi client - will be redirected to the official repo | ||
| "wokwi-client @ git+https://github.com/JakubAndrysek/wokwi-python-client.git@add-sync-client", | ||
| # Temporary workaround - will be fixed for stable release | ||
| "wokwi-client", |
There was a problem hiding this comment.
Hi @JakubAndrysek I saw the https://github.com/wokwi/wokwi-python-client/releases/tag/v0.1.0 has been released. could you update the requirements to
wokwi-client>=0.1.0,<1 here?
There was a problem hiding this comment.
Yes, I will do it, but I am still waiting to release version 1.0.1 with some other improvements which I need in pytest.
But the rest of the code will be the same.
|
Hi, the PR is ready. Please review it, thanks! |
This pull request migrates the Wokwi integration in
pytest-embedded-wokwifrom a CLI-based approach (wokwi-cli) to a new synchronous Python client (wokwi-python-client). It removes all dependencies and code related to the CLI, introduces a newWokwiclass for simulation control, and updates documentation and dependencies accordingly. The changes also update all relevant imports and interfaces in the codebase to use the newWokwiclass, and improve the documentation with usage examples for the new API.