new variant Seeed XIAO_ESP32S3 #7971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechBartoska
added
the
Type: 3rd party Boards
P-R-O-C-H-Y
requested changes
Apr 3, 2023
P-R-O-C-H-Y
added
Resolution: Awaiting response
and removed
Status: Review needed
|
@P-R-O-C-H-Y Thanks! I noticed these issues and addressed them one by one in the latest commit. |
P-R-O-C-H-Y
approved these changes
Apr 4, 2023
P-R-O-C-H-Y
added
Status: Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
new variant Seeed XIAO_ESP32S3
Tests scenarios
I have tested my Pull Request on Arduino-esp32 core v2.0.2 with Seeed XIAO_ESP32S3 Board