Skip to content

add mising TX1 RX1 for adafruit boards #7680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

add mising TX1 RX1 for adafruit boards #7680

merged 1 commit into from
Jan 9, 2023

Conversation

hathach
Copy link
Contributor

@hathach hathach commented Jan 9, 2023

Description of Change

This PR add missing symbol TX1 and RX1 for Adafruit boards, which fixed issue reported by Adafruit user here https://forums.adafruit.com/viewtopic.php?p=954722

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core (master branch 2.0.6) with Adafruit Feather ESP32-S2 TFT with SerialPassThrough example.

@ladyada

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jan 9, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Jan 9, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y merged commit 778674b into espressif:master Jan 9, 2023
@hathach
Copy link
Contributor Author

hathach commented Jan 9, 2023

thank you for the the quick merge !!

@hathach hathach deleted the adafruit-tx1-rx1 branch February 3, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hathach @P-R-O-C-H-Y