Skip to content

Conversation

mjysci
Copy link
Contributor

@mjysci mjysci commented Oct 19, 2022


Description of Change

Please describe your proposed Pull Request and it's impact.

This PR fix 2 errors so that we can upload the compiled firmware successfully to AirM2M_CORE_ESP32C3 board.

  1. Property 'upload.tool.serial' is undefined
  2. esptool write_flash: error: argument : Address "{upload.erase_cmd}" must be a number
    Failed uploading: uploading error: exit status 2

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

I have tested my Pull Request on Arduino-esp32 core v2.0.5 with AirM2M_CORE_ESP32C3 Board with this scenario.

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2022

CLA assistant check
All committers have signed the CLA.

@VojtechBartoska VojtechBartoska added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Oct 21, 2022
@VojtechBartoska
Copy link
Contributor

@P-R-O-C-H-Y or @PilnyTomas, please review and help with merging of this PR

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Oct 24, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y merged commit c58f756 into espressif:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants