LEDC 1-bit mode duty fix. #7079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
With this previous change we fixed if all bits from given resolution are set, then the LEDC PWM should be full on. But 1-bit mode duty option is 0 - fully off or 1 -fully on which is wrong. As it is in ESP-IDF docs the 1-bit PWM means the duty cycle is fixed at 50%.
This PR fixes that to align with ESP-IDF docs.
Tests scenarios
Tested on ESP32 nad ESP32S3. No need to test on all chips.
Related links
Closes #7067