Skip to content

Conversation

mrengineer7777
Copy link
Collaborator

@mrengineer7777 mrengineer7777 commented Jan 7, 2022

Summary

I2C Slave currently doesn't compile for projects where Arduino is an IDF component. This adds missing conditionals.

Impact

esp32-hal-i2c-slave.c will compile

Related links

N/A

I2C Slave currently doesn't compile for projects where Arduino is an IDF component.  This adds missing conditionals.
@CLAassistant
Copy link

CLAassistant commented Jan 7, 2022

CLA assistant check
All committers have signed the CLA.

@Jason2866
Copy link
Collaborator

@mrengineer7777
Copy link
Collaborator Author

mrengineer7777 commented Jan 11, 2022

@mrengineer7777 This is needed too https://github.com/tasmota/arduino-esp32/pull/47/files

@Jason2866 That fix is in "esp32-hal-spi.c" and appears unrelated to my fix in "esp32-hal-i2c-slave.c".

@Jason2866
Copy link
Collaborator

I thought you want to fix all issues when Arduino is used as IDF component.

@mrengineer7777
Copy link
Collaborator Author

I thought you want to fix all issues when Arduino is used as IDF component.

@Jason2866 Gotcha. I just found the repository "tasmota / arduino-esp32". Impressive work!

@Jason2866
Copy link
Collaborator

The real impressive (why it is made) is the project which use -> https://github.com/arendst/Tasmota

@mrengineer7777
Copy link
Collaborator Author

@me-no-dev It appears the automated checks failed because of a network timeout.

@me-no-dev me-no-dev merged commit 460af2e into espressif:master Jan 17, 2022
@me-no-dev
Copy link
Member

merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants