Skip to content

Conversation

VojtechBartoska
Copy link
Contributor

@VojtechBartoska VojtechBartoska commented Dec 9, 2021

Summary

This PR contains adding:

  • Issue template using forms
  • Feature Template using forms
  • Update of Pull Request template

All yaml files have been checked by online validator.

Pages are rendered here (for easier review):
Feature Request template
Issue Template

Impact

These templates can help with more accurate issue/PR explanations which can improve handling these contribution and in overall have a positive influence on User experience.

Related links

This PR closed issue #5956

@VojtechBartoska VojtechBartoska added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Dec 9, 2021
@VojtechBartoska VojtechBartoska linked an issue Dec 9, 2021 that may be closed by this pull request
@VojtechBartoska VojtechBartoska self-assigned this Dec 9, 2021
@VojtechBartoska VojtechBartoska removed the request for review from pedrominatel December 9, 2021 17:42
@VojtechBartoska VojtechBartoska marked this pull request as draft December 9, 2021 17:43
@VojtechBartoska
Copy link
Contributor Author

Marking as draft, found some typos and mistake in issue-template. Will be fixed in next commit.

@VojtechBartoska VojtechBartoska marked this pull request as ready for review December 10, 2021 11:57
Copy link
Member

@radimkarnis radimkarnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments, otherwise LGTM!

@VojtechBartoska
Copy link
Contributor Author

PTAL @pedrominatel, thanks!

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change. LGTM!

@me-no-dev me-no-dev merged commit 2463f57 into espressif:master Dec 14, 2021
@VojtechBartoska VojtechBartoska deleted the Update_templates branch December 14, 2021 14:06
aIecxs pushed a commit to aIecxs/arduino-esp32 that referenced this pull request Oct 24, 2024
Summary

This PR contains adding:

Issue template using forms
Feature Template using forms
Update of Pull Request template
All yaml files have been checked by online validator.

Pages are rendered here (for easier review):
Feature Request template
Issue Template

Impact

These templates can help with more accurate issue/PR explanations which can improve handling these contribution and in overall have a positive influence on User experience.

Related links

This PR closed issue espressif#5956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Add Issue/Bug/Feature templates using forms format
4 participants