[1.0.5] Update Heltec ESP32 series boards definition #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

me-no-dev merged 4 commits into espressif:master from Heltec-Aaron-Lee:master

Dec 2, 2020

Contributor

Heltec-Aaron-Lee commented Nov 25, 2020

Added LoRaWAN features option for Heltec ESP32 + LoRa series boards;
Added a new board Heltec Wireless Stick Lite.


          Update Heltec ESP32 series boards definition

be855a1

Heltec-Aaron-Lee mentioned this pull request

Unauthorized users can't submit PR anymore? #4578

Closed

me-no-dev reviewed

View reviewed changes

platform.txt Outdated Show resolved Hide resolved

me-no-dev reviewed

View reviewed changes

platform.txt Outdated Show resolved Hide resolved

me-no-dev changed the title ~~Update Heltec ESP32 series boards definition~~ [1.0.5] Update Heltec ESP32 series boards definition

Heltec-Aaron-Lee added 2 commits

December 2, 2020 16:58


          Update LoRaWAN compile options

bdd53b3


          Restore to original platform.txt

08f4360

Heltec-Aaron-Lee closed this

Heltec-Aaron-Lee reopened this

Contributor Author

Heltec-Aaron-Lee commented Dec 2, 2020

Thank you for your hints, I had fixed the PR request, please confirm again.

me-no-dev reviewed

View reviewed changes

variants/heltec_wifi_kit_32/pins_arduino.h Outdated Show resolved Hide resolved

me-no-dev reviewed

View reviewed changes

variants/heltec_wifi_lora_32/pins_arduino.h Outdated Show resolved Hide resolved

me-no-dev reviewed

View reviewed changes

variants/heltec_wifi_lora_32_V2/pins_arduino.h Outdated Show resolved Hide resolved

me-no-dev reviewed

View reviewed changes

variants/heltec_wireless_stick/pins_arduino.h Outdated Show resolved Hide resolved

me-no-dev reviewed

View reviewed changes

variants/heltec_wireless_stick_lite/pins_arduino.h Show resolved Hide resolved

Member

me-no-dev commented Dec 2, 2020

Almost there :) sorry I missed the deleted definitions earlier


          Add LED_BUILTIN define

8cf6d7f

Contributor Author

Heltec-Aaron-Lee commented Dec 2, 2020

Thank you for your fast response, just updated. 😃

Member

me-no-dev commented Dec 2, 2020

@Heltec-Aaron-Lee waiting for CI to complete and will merge :)

Contributor Author

Heltec-Aaron-Lee commented Dec 2, 2020

👍 👍 👍

me-no-dev merged commit aac26a4 into espressif:master

platypii mentioned this pull request

Update boards.txt file to fix some of the broken board.build entries that should be upper case #7942

Closed

P-R-O-C-H-Y mentioned this pull request

Fix Heltec boards build.board to be uppercase #8958

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet