Skip to content

Fix string to bytes conversion (GIT8266O-868) #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix string to bytes conversion (GIT8266O-868) #1290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/esptool_py/esptool/esptool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,6 +1287,9 @@ def warn_if_unusual_segment(self, offset, size, is_irom_segment):
def save_segment(self, f, segment, checksum=None):
""" Save the next segment to the image file, return next checksum value if provided """
f.write(struct.pack('<II', segment.addr, len(segment.data)))
# Ensure segment.data is in bytes
if isinstance(segment.data, str):
segment.data = segment.data.encode('utf-8') # Encode string to bytes
f.write(segment.data)
if checksum is not None:
return ESPLoader.checksum(segment.data, checksum)
Expand Down