Skip to content

Allow for POSTs larger than a few 100 bytes #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2019
Merged

Allow for POSTs larger than a few 100 bytes #6800

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7ef9ad
Allow for POSTs larger than a few 100 bytes
earlephilhower Nov 18, 2019
6e4d3df
Merge branch 'master' into dirkx-fix
earlephilhower Nov 18, 2019
6d24c50
Merge branch 'master' into dirkx-fix
earlephilhower Nov 21, 2019
4474629
Merge branch 'master' into dirkx-fix
devyte Nov 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions libraries/ESP8266HTTPClient/src/ESP8266HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,9 +677,20 @@ int HTTPClient::sendRequest(const char * type, const uint8_t * payload, size_t s
}

// send Payload if needed
if(payload && size > 0) {
if(_client->write(&payload[0], size) != size) {
return returnError(HTTPC_ERROR_SEND_PAYLOAD_FAILED);
if (payload && size > 0) {
size_t byteswritten = 0;
const uint8_t *p = payload;
while (byteswritten < size) {
int written;
int towrite = std::min((int)size, (int)HTTP_TCP_BUFFER_SIZE);
written = _client->write(p, towrite);
if (written < 0) {
return returnError(HTTPC_ERROR_SEND_PAYLOAD_FAILED);
} else if (written == 0) {
return returnError(HTTPC_ERROR_CONNECTION_LOST);
}
byteswritten += written;
size -= written;
}
}

Expand Down