EspSoftwareSerial release 5.2.1 #6219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78aa3e8.
…by end-bit detection without checking for same-level timestamps from the IRQ
…missing attachInterruptArg in Arduino.h
…chInterruptArg in ESP8266 Arduino
dok-net
changed the title
|
@earlephilhower After finding a one-liner way of back-porting from my attachInterruptArg PR(s), this is finally the long awaited release 5.2.1 of EspSoftwareSerial. I've you have a moment of time, could you please confirm to me how your basic tests perform? I'd expect noticeably improved performance, respectively lower error rates. I am quite curious what the handful of users that have issues with the ESP8266 and SoftwareSerial will be saying. |
earlephilhower
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
@dok-net, I'm not actually a SW Serial user but seems good to me.
d-a-v
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the std::bind workaround via FunctionInterrupt while attachInterruptArg is pending.