IPAddress: allow misaligned source in constructor

[d-a-v]

fix #5420

[TD-er]

Just to get an idea of the impact of this fix.
In what circumstances would this go wrong?

I have looked at my project's source code and it seems we're using this constructor of IPAddress from our settings file and maybe some other instances too.
This settings file is a struct which is read as a byte stream from the SPIFFS.
So it may differ per build where this struct is being allocated (on the sys stack).

In what circumstances is this going wrong? Is it compiler dependent?

[d-a-v]

In what circumstances would this go wrong?

Before this PR and after the IPv6 commit, we were doing in #5420 uint32_t addr = *(uint32_t*)(4*x + 2) <- reading 4bytes from adresses not multiple of 4 causes an exception.

I have looked at my project's source code and it seems we're using this constructor of IPAddress from our settings file and maybe some other instances too.

This constructor now works like the previous one (before the IPv6 commit). Reading pointer byte by byte is misalignment-proof. memcpy() would work too.

[TD-er]

OK, thanks for the explanation.