Terminate chunked responses in ESP8266WebServer #3963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrr
force-pushed
the
bugfix/webserver_chunked_terminate
branch
2 times, most recently
from
806ded3 to
400ea9e
Compare
devyte
requested changes
Dec 16, 2017
| } | ||
|
|
||
|
|
||
| void ESP8266WebServer::_cleanup() { |
There was a problem hiding this comment.
Is this really cleanup? Maybe change to finalize or similar
igrr
force-pushed
the
bugfix/webserver_chunked_terminate
branch
from
8409509 to
fe1091b
Compare
|
@devyte Renamed |
devyte
approved these changes
Dec 26, 2017
igrr
force-pushed
the
bugfix/webserver_chunked_terminate
branch
from
4dc2736 to
11febf4
Compare
d-a-v
added a commit
to d-a-v/Arduino
that referenced
this pull request
Dec 28, 2017
…ates and fixes lwip2 updates: > multi-mss makefile > forwardported espconn (no multicast yet) > restore max 3 ntp servers for configTime() coherency > unchain seldom chained pbufs > dns cache name length back to (256->48->) 128 > use sntp_stop/start() when dhcp address got > fix netif's hostname glue-handling > forwardported ping from lwip1.4 fix esp8266#3970 fix maybe esp8266#3963
devyte
pushed a commit
that referenced
this pull request
Dec 29, 2017
…ates and fixes (#4039) lwip2 updates: > multi-mss makefile > forwardported espconn (no multicast yet) > restore max 3 ntp servers for configTime() coherency > unchain seldom chained pbufs > dns cache name length back to (256->48->) 128 > use sntp_stop/start() when dhcp address got > fix netif's hostname glue-handling > forwardported ping from lwip1.4 fix #3970 fix maybe #3963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When request handler is done, and chunked encoding was used, server should send a zero-length chunk to indicate that the response is complete.
It is possible that some sketches already send a zero-length chunk as part of the request handler, so reset
_chunkedflag when zero-length chunk is encountered.Fixes #3225.
Also add CONTENT_LENGTH_UNKNOWN to the keywords list.