Skip to content

Fix pulseIn #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2016
Merged

Fix pulseIn #1768

merged 1 commit into from
Mar 30, 2016

Conversation

@igrr
Copy link
Member

@igrr igrr commented Mar 13, 2016

#1072
#1149

  • fix return value on timeout
  • add optimistic_yield to allow WiFi/network tasks to run
  • use ccount instead of micros (which causes an integer division on every call)

@igrr
Fix pulseIn (#1072, #1149)
32c6176 
- fix return value on timeout
- add optimistic_yield to allow WiFi/network tasks to run
- use ccount instead of micros (which causes an integer division on every call)
@mangelajo
Copy link
Contributor

mangelajo commented Mar 28, 2016

looks good to me.

@igrr igrr merged commit 2e849e3 into master Mar 30, 2016
@igrr igrr deleted the pulsein_fix branch April 13, 2016 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igrr @mangelajo