Skip to content

Version 3.1.0 #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2024
Merged

Version 3.1.0 #639

merged 4 commits into from
May 27, 2024

Conversation

@SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented May 24, 2024 •
edited
Loading

  • Update changelog
  • Bump espflash and cargo-espflash version
  • Update dependencies
  • Bump MSRV to 1.76.0

MabezDev
MabezDev reviewed May 24, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the MSRV bump affect the library, or just the binaries? If it affects the library then its a breaking change :(

@MabezDev
Copy link
Member

Ah I see you've done it in this PR - was there a reason to do so? If not IMO we should revert.

@SergioGasquez
Copy link
Member Author

Does the MSRV bump affect the library, or just the binaries? If it affects the library then its a breaking change :(

I think it should affect cargo-espflash only, as the failing crate was cargo, see https://github.com/esp-rs/espflash/actions/runs/9221103611/job/25369434066

@MabezDev
Copy link
Member

Maybe we should make the MSRV check only check for the library then, and make no guarantee about the binaries (they can install from binstall or gh releases if they want stability)?

MabezDev
MabezDev reviewed May 24, 2024
View reviewed changes
MabezDev
MabezDev approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@SergioGasquez SergioGasquez merged commit c034fe0 into esp-rs:main May 27, 2024
@SergioGasquez SergioGasquez deleted the feat/release branch May 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MabezDev MabezDev MabezDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SergioGasquez @MabezDev