Adding support for Waveshare ESP32-S3-Touch-LCD-1.85 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lzw655
reviewed
Oct 25, 2024
Collaborator
There was a problem hiding this comment.
Fantastic, a very good update, thank you so much for your contribution. Apart from the comments below, I have just two suggestions:
- Since the repository uses pre-commit to check code standards, please install and run pre-commit after completing all modifications by following the command below.
Install: pip3 install pre-commit && pre-commit install
Run: pre-commit run --all-filesThen, review the changes automatically generated by pre-commit and, if everything looks good, simply save them. You can see the GitHub Action results for the pre-commit check.
- Squash all commits in the PR into a single commit.
Todo: - Doc files - README - PanelVersions - CHANGELOG Update Board_Instructions.md Update README.md Update README_CN.md Update ESP_PanelVersions.h Update CHANGELOG.md Update src/board/ESP_PanelBoard.h Co-authored-by: Zhongwei Liu <[email protected]> Suggested updates Pre-commit success
Contributor
Author
|
Alright, I think I managed to make it all as intended, including the squashing (not my forte). Let's go for a second round ? |
Collaborator
|
Thank you for your revisions. It’s now a perfect PR. Let’s merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should contain all the necessary changes to add support for the touch version of the 1.85in touch LCD ESP32S3 module from Waveshare.