no-alert and others

[kof]

They should be smart enough to recognize that I am not calling window.alert. I have a component named alert and its declared like this var alert = require('components/notification/alert')

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[nzakas]

Is there a reason you don't turn off no-alert?

[kof]

yes I don't want somebody uses window.alert, as it is supposed by this linter ... alert in my implementation is a custom ui.

[nzakas]

I'm not sure this is easily achievable. Basically we'd need to keep track of alert wherever it's used to see if it's the native one or not. I'll leave this issue open in case someone wants to investigate, but this is pretty low priority compared to our other issues.

[jonvuri]

Personally I think this is a valid application of the rule - that is, it should flag this case. Shadowing 'alert' means that if you copy-and-paste any of the code, or otherwise exit the shadowed scope, you suddenly have a wild alert statement in your code. It's a visible bug waiting to happen. You should just name the variable something else that doesn't shadow a dangerous global.

[kof]

Shadowing 'alert' means that if you copy-and-paste any of the code,

no its ok to copy paste it. Your new location will do the same check and if its not declared, linter will warn. If you copy that to an application which isn't using linter -> different issue.

[michaelficarra]

I agree with @kof. I think it's reasonable to expect no-alert to understand when a reference is to the global alert and when it has been shadowed. Same thing with no-console.

As for implementation, this can be easily done by either making use of escope (the reference won't have a resolved pointer to the declaration) or keeping track of shadowing ourselves similar to what we do in the block-scoped-var rule.

[rlidwka]

Shadowing 'alert' means that if you copy-and-paste any of the code, or otherwise exit the shadowed scope, you suddenly have a wild alert statement in your code.

Is there a way to explicitly turn off global alert, so no-undef rule will treat it as undefined variable?

Because this is much better solution than tracking where alert variable is coming from. no-undef rule already does that.

[nzakas]

You'd need to disable the browser environment to do that. There's no way to undefine a global one it's been defined.