Plugin status and discussion

[gyandeeps]

Available plugins

• Triage - It add the triage label to the issues which doesn't have any labels.
• Commit message check - It checks the first commit message on PR and make sure it is formatted according to the guidelines. If not then it leaves a message on the PR.
• Duplicate comments - It removes all the duplicates comments by this bot and leaves the last one of each type. It uses a unique hash from the comment message.
• PR ready to merge* - Checks if the PR is ready to merge and if it is then it adds the pr: ready to merge label.
  • At least one review is approved.
  • Build status is success.
• Check unit test* - Make sure the PR contains unit test. This check will be ignored for Build|Chore|Docs|Upgrade PR title.
• More info - It adds the template for more info to the issue where the more info label is added.

Questions/Discussion

• Which of the available plugins needs to be disabled? (currently all of them are active)
• Any other plugins we need?

[nzakas]

I'm not sure how useful removing duplicate comments is. The problem now is that the duplicate comments trigger notifications. Just removing the duplicate comments after they are made won't solve that problem. I'd vote for disabling that plugin.

Does the ready to merge PR need to take into account PRs that need TSC approval? Just worried that non-TSC member might approve a PR that needs a TSC member to merge. The tag could be misleading.

I'd love to see a plugin that helps with forgotten issues/PRs, maybe by leaving a comment if there has been no activity within a certain amount of time. (I'd also love to automatically close issues that are old enough, but I know not everyone likes that).

[gyandeeps]

I'm not sure how useful removing duplicate comments is. The problem now is that the duplicate comments trigger notifications. Just removing the duplicate comments after they are made won't solve that problem. I'd vote for disabling that plugin.

You are right it doesn't solve the notification issue but i think it minimizes the clutter on the issue/PR. Example eslint/eslint#8852 , there are so many repeated comments by bot that the its gets annoying after a while. At least that problem can be solved.
In the future we can move from comment to a more status based check where comments or commit message will mark status on the PR.

Does the ready to merge PR need to take into account PRs that need TSC approval? Just worried that non-TSC member might approve a PR that needs a TSC member to merge. The tag could be misleading.

You are right. Currently it doesn't not take into account TSC label but what we can do is that we can make it to where it checks for accepted label as well and then only it will mark ready to merge.
On top of that we can also check if any required reviewers are still left to review the code.

I'd love to see a plugin that helps with forgotten issues/PRs, maybe by leaving a comment if there has been no activity within a certain amount of time. (I'd also love to automatically close issues that are old enough, but I know not everyone likes that).

I think this can be done by making that plugin run nightly using a timer.

[nzakas]

Turns out that the new code owners feature might be useful for the PR-TSC situation. https://github.com/blog/2392-introducing-code-owners

[not-an-aardvark]

Looking good -- I think we should be ready to replace the regular eslintbot. However, can we turn off the pr-ready-to-merge thing for now, until we decide what to do with the code owners feature? There are also a few other concerns I had with that check -- for example, a PR might not be ready to merge if:

• It doesn't have the accepted label
• It hasn't been open for 2 days
• We're waiting for a particular person's review

[alberto]

I'd love to see a plugin that helps with forgotten issues/PRs, maybe by leaving a comment if there has been no activity within a certain amount of time. (I'd also love to automatically close issues that are old enough, but I know not everyone likes that).
I think this can be done by making that plugin run nightly using a timer.

Hah! This is the first thing I thought when you told us about the bot :)

[alberto]

You are right. Currently it doesn't not take into account TSC label but what we can do is that we can make it to where it checks for accepted label as well and then only it will mark ready to merge.
On top of that we can also check if any required reviewers are still left to review the code.

I think @nzakas was not referring to acceptance of the issue/PR but instead about some kind of PRs requiring a TSC review approval.

[not-an-aardvark]

Ping -- is there anything blocking us from replacing eslintbot with eslint-github-bot?