hw2 #1
hw2 #1
Conversation
|
Вариант #17 |
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 88.41%
=======================================
Files ? 5
Lines ? 233
Branches ? 0
=======================================
Hits ? 206
Misses ? 27
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
lib/utils/src/utils.c
Outdated
| char *word = strtok(copy, " "); | ||
| if (word == NULL) { | ||
| free(copy); |
There was a problem hiding this comment.
Ради использования strtock ты создаешь дополнительный буффер размером 100мб? А если входная строка будет 10гб?
lib/word_search/src/word_search.c
Outdated
| if (longest_word == NULL) { | ||
| free(string_of_words); | ||
| return NULL; | ||
| } |
There was a problem hiding this comment.
ты не должен удалять переданный из вне массив внутри функции
lib/word_search/src/word_search.c
Outdated
| return NULL; | ||
| } | ||
|
|
||
| char *longest_word = (char *) malloc(strlen(string_of_words) * sizeof(char)); |
| char mtext[BUFF_SIZE]; | ||
| } message_buff; | ||
|
|
||
| char *find_longest_word(char *string_of_words) { |
lib/word_search/src/word_search.c
Outdated
| while (string_of_words[i] != ' ' && string_of_words[i] !='\0') { | ||
| current_word[j] = string_of_words[i]; | ||
| i++; | ||
| j++; | ||
| } |
There was a problem hiding this comment.
лучше вынести в функцию принимающую char *dest, const char *src
| } message_buff; | ||
|
|
||
|
|
||
| void child_procs_work(char *string_of_words, size_t current_procs_numb, size_t number_of_procs, int q_id) { |
No description provided.