Added support for Dremio. #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Dremio docker image to the CI integration testing. * The `vertica` docker image is missing from dockerhub and is returning 404, so the vertica test is commented out. * Added python version markers to pyarrow, pandas and numpy as they each drop support for Python 3.8 so for working with Python 3.8 we need to install the last compatible version. * The cursor is the implementation in `sqlalchemy-dremio`. The current release of `sqlalchemy-dremio` (3.0.4) does not support datetime[ms]. The fix is on the master branch of `sqlalchemy-dremio` but the master branch dependency versions are not compatible with Python 3.8. To have the CI tests pass with Python 3.8, we use a fork of `sqlalchemy-dremio` that contains the fix but has compatible dependencies.
This was referenced Aug 28, 2025
erezsh
requested changes
Aug 30, 2025
|
|
||
| return super().parse_type(table_path, col_name, type_repr, datetime_precision, numeric_precision, numeric_scale) | ||
|
|
||
| def set_timezone_to_utc(self) -> str: |
There was a problem hiding this comment.
If Dremio works in UTC by default, shouldn't this method just pass without failing?
| 'queries instead.' | ||
| ) | ||
|
|
||
| def type_repr(self, t) -> str: |
| ) -> ColType: | ||
| from math import isnan | ||
| if datetime_precision is not None and not isinstance(datetime_precision, int): | ||
| if isnan(datetime_precision): |
There was a problem hiding this comment.
This should probably be a function (e.g. nan_to_none())
| numeric_precision: int = None, | ||
| numeric_scale: int = None, | ||
| ) -> ColType: | ||
| from math import isnan |
There was a problem hiding this comment.
imports always at module level (unless there's a good reason not to)
|
(Just a few changes / responses necessary) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verticadocker image is missing from dockerhub and is returning 404, so the vertica test is commented out.sqlalchemy-dremio. The current release ofsqlalchemy-dremio(3.0.4) does not support datetime[ms]. The fix is on the master branch ofsqlalchemy-dremiobut the master branch dependency versions are not compatible with Python 3.8. To have the CI tests pass with Python 3.8, we use a fork ofsqlalchemy-dremiothat contains the fix but has compatible dependencies. sqlalchemy_dremio/issues/58