fix: Expand and clarify hook state behavior in the spec #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-alchemy
force-pushed
the
adam/expand-hook-spec
branch
from
85ae3f9 to
7272c0c
Compare
jaypaik
force-pushed
the
adam/expand-hook-spec
branch
from
7272c0c to
fc9de69
Compare
jaypaik
force-pushed
the
adam/expand-hook-spec
branch
from
fc9de69 to
3b85fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ERC-6900 spec has a (somewhat) ambiguous comment about which hooks should be run, because it implies a special casing for
uninstallPluginspecifically. The behavior described there should apply to all execution functions.Solution
Expand that note into two sentences and clarify that it applies to all execution functions, along with some rationale.
Note that this does not fully extend the requirement to load all account state that is used, it specifically only requires it for hooks, as it was before.
We should consider extending this requirement to the validation and execution functions themselves.