feat: add PluginStorageLib, AssociatedLinkedListSetLib #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-alchemy
approved these changes
Jan 10, 2024
Contributor
adam-alchemy
left a comment
adam-alchemy
left a comment
There was a problem hiding this comment.
Looks good, thanks for porting over to publish.
jaypaik
deleted the
01-10-feat_add_PluginStorageLib_AssociatedLinkedListSetLib
branch
huaweigu
reviewed
Jan 18, 2024
Contributor
huaweigu
left a comment
huaweigu
left a comment
There was a problem hiding this comment.
Do you plan to use any of these data structures in account storage?
| } | ||
|
|
||
| /// @notice Removes a value from a set. | ||
| /// @dev This is an O(n) operation, where n is the number of elements in the set. |
Contributor
There was a problem hiding this comment.
We initially thought about using a linked list. It's also O(n) for deleting random item without knowing its previous item. (O(1) if previous item is known)
We then used a doubly linked list at the cost of storage. I guess it's a tradeoff.
| /// @dev This is an O(n) operation, where n is the number of elements in the set. | ||
| /// @param set The set to get the elements of. | ||
| /// @return res An array of all elements in the set. | ||
| function getAll(AssociatedLinkedListSet storage set, address associated) |
Contributor
There was a problem hiding this comment.
We also implemented pagination, which was a nice feature from web2 APIs. But it's probably a overkill for most of accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some libraries that help in accessing account associated storage in plugins.