feat: remove onchain 165 interface check during install #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: cafc5a7 |
This comment was marked as resolved.
This comment was marked as resolved.
Zer0dot
approved these changes
Feb 13, 2025
|
Thanks for taking care of this! |
jaypaik
pushed a commit
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ERC-6900 specification does not require that the account perform an ERC-165 interface check when installing a module, just that the module must implement that interface, Per a discussion in the working group and with the OpenZeppelin team, we will remove the onchain check during installation from the reference implementation to avoid encouraging this non-standard behavior.
Solution
Remove the ERC-165 interface check during
_onInstallin ModuleManagerInternals.