Skip to content

Conversation

@huaweigu
Copy link
Contributor

@huaweigu huaweigu commented Nov 6, 2024

Motivation

It'd be helpful for devs to import this project (especially libraries) as a npm package.

Update - package is published here.

Solution

  • Update package.json to be npm publish ready
  • TODO - automate this in action in the future similar to this
    publish-npm:
     needs: build
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           registry-url: https://registry.npmjs.org/
       - run: npm ci
       - run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
           token: ${{ secrets.NPM_TOKEN }}
    we just need to figure out where to host the secrets.

package.json Outdated
{
"name": "@erc6900/reference-implementation",
"version": "0.8.0-rc.5",
"name": "erc6900-reference-implementation",
Copy link
Contributor Author

@huaweigu huaweigu Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tired the original name first, but got

npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@erc6900%2freference-implementation - Not found
npm ERR! 404 
npm ERR! 404  '@erc6900/[email protected]' is not in this registry.
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

This solution or this doc requires the user to sign up with erc6900 scope, but it is already in use..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I submitted a name dispute request. Would love to keep the org scope if possible...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it'd be great if we can get erc6900 back. I tried user name and org name, both unavailable..

@huaweigu huaweigu requested a review from a team November 6, 2024 20:19
package.json Outdated
"version": "0.8.0-rc.5",
"name": "erc6900-reference-implementation",
"description": "Reference implementation for [ERC-6900](https://eips.ethereum.org/EIPS/eip-6900).",
"version": "0.8.0-rc.6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huaweigu Mind bumping this to 0.8.1 and updating the package name/relevant bits now that we have the erc6900 org on npm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 2bbfacc

I also published the package here

@@ -1,15 +1,31 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaypaik Let me know if we need to adjust any metadata, thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@huaweigu huaweigu requested review from a team and jaypaik March 25, 2025 14:24
@huaweigu huaweigu merged commit 65892c2 into erc6900:develop Mar 27, 2025
3 checks passed
@huaweigu huaweigu deleted the feat/npm branch March 27, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants