-
Notifications
You must be signed in to change notification settings - Fork 29
feat: update package json for npm publish #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
package.json
Outdated
| { | ||
| "name": "@erc6900/reference-implementation", | ||
| "version": "0.8.0-rc.5", | ||
| "name": "erc6900-reference-implementation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tired the original name first, but got
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@erc6900%2freference-implementation - Not found
npm ERR! 404
npm ERR! 404 '@erc6900/[email protected]' is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.
This solution or this doc requires the user to sign up with erc6900 scope, but it is already in use..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I submitted a name dispute request. Would love to keep the org scope if possible...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it'd be great if we can get erc6900 back. I tried user name and org name, both unavailable..
package.json
Outdated
| "version": "0.8.0-rc.5", | ||
| "name": "erc6900-reference-implementation", | ||
| "description": "Reference implementation for [ERC-6900](https://eips.ethereum.org/EIPS/eip-6900).", | ||
| "version": "0.8.0-rc.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huaweigu Mind bumping this to 0.8.1 and updating the package name/relevant bits now that we have the erc6900 org on npm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -1,15 +1,31 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaypaik Let me know if we need to adjust any metadata, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Motivation
It'd be helpful for devs to import this project (especially libraries) as a npm package.
Update - package is published here.
Solution
package.jsonto benpm publishready