chore: rename constant

[huaweigu]

Motivation

Rename ENTITYID to snake_case ENTITY_ID for readability.

Solution

Rename the constant.

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

• ReferenceModularAccount.sol: The primary change involves a minor correction in naming from DIRECT_CALL_VALIDATION_ENTITYID to DIRECT_CALL_VALIDATION_ENTITY_ID.
• Constants.sol: Renamed DIRECT_CALL_VALIDATION_ENTITYID to DIRECT_CALL_VALIDATION_ENTITY_ID.
• ReturnDataModuleMocks.sol: Updated a constant name for consistency in the smart contract's validation process.

---

🔗 Commit Hash: 5add5b4

[octane-security-app]

Overview

Vulnerabilities found:	4
Severity breakdown:	1 Critical, 1 High, 2 Medium

Detailed findings

src/account/ReferenceModularAccount.sol

• Review potential Denial of Service issue that is exposed in the __fallback__ function
• Review potential External Calls issue that is exposed in the executeUserOp function
• Review potential Incorrect Nonce Update (Signature Replay Attack) issue that is exposed in the __fallback__ function
• Review potential Reentrancy issue that is exposed in the __fallback__ function

---

🔗 Commit Hash: 5add5b4
🛡️ Octane Dashboard: All vulnerabilities

[huaweigu]

@adamegyed @fangting-alchemy @jaypaik could you please take a look? Thanks

[jaypaik]

lgtm! happy to cut a new tag including this change once this is in

[huaweigu]

lgtm! happy to cut a new tag including this change once this is in

That'd be great, thank you!

[jaypaik]

@huaweigu This is now available on https://github.com/erc6900/reference-implementation/releases/tag/v0.8.0-rc.6

[huaweigu]

@huaweigu This is now available on https://github.com/erc6900/reference-implementation/releases/tag/v0.8.0-rc.6

Thank you!