refactor: fix ERC20TokenLimitModule and remove dependency on modular-account-libs #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: a2bd984 |
This comment was marked as resolved.
This comment was marked as resolved.
huaweigu
reviewed
Oct 8, 2024
| struct ERC20SpendLimit { | ||
| address token; | ||
| uint256[] limits; | ||
| uint256 limit; |
Contributor
There was a problem hiding this comment.
Is this struct only used in installation?
adamegyed
approved these changes
Oct 8, 2024
jaypaik
deleted the
10-07-refactor_fix_ERC20TokenLimitModule_and_remove_dependency_on_modular-account-libs
branch
jaypaik
added a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ERC20TokenLimitModule with some fixes and removes the modular-account-libs dependency.