Skip to content

Conversation

@adamegyed
Copy link
Contributor

Motivation

Spec cleanup and finalization.

Solution

Remove inaccurate todos.

Adjust capitalization.

Fill out backwards compatibility section.

## Backwards Compatibility

TODO
Existing accounts that are deployed as proxies may have the ability to upgrade account implementations to one that supports this standard for modularity. Depending on implementation logic, existing modules may be wrapped in an adapter contract to adhere to the standard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should mention anything related to storage re: upgrades?

Technically speaking, the RI namespaces storage, but is that expected of other implementations? If not, that could cause issues with upgrades. Do you think we ought to mention a little warning about storage collisions here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The focus of this section is on backwards compatibility, and because the standard is proxy-agnostic (whether or not you use one at all), I'm not sure we want to introduce it here. If we explicitly call out namedspaced storage (ERC-7201) then we also have to add it to the dependencies list, and I think it's probably not worth introducing the dependency just for this section.

Maybe we just add a sentence like "Users should exercise caution when doing proxy upgrades, and verify that no issues, such as storage collisions, occur in the process." ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine as is then-- better not bleed into proxies in that case!

@adamegyed adamegyed merged commit c5c3091 into develop Aug 30, 2024
@adamegyed adamegyed deleted the adam/spec-misc-fixes branch August 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants