feat: pack hook config #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypaik
approved these changes
Aug 29, 2024
adamegyed
force-pushed
the
adam/add-validation-uo-flag
branch
2 times, most recently
from
e3d31f2 to
22ff5e5
Compare
adamegyed
force-pushed
the
adam/pack-hook-config
branch
from
958b072 to
0e19879
Compare
adamegyed
force-pushed
the
adam/pack-hook-config
branch
from
0e19879 to
f3c0514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #160 we packed
ValidationConfigefficiently into abytes25type. For consistency, we should do the same for theHookConfigtype.Solution
Change
HookConfigto abytes25type.Pack all flags efficiently in the final byte, rather that spreading it out over 2 bytes.
Update usage in the account and tests.