Skip to content

Conversation

@fangting-alchemy
Copy link
Collaborator

No description provided.

An account can have the same validation module installed more than once.
The entityId of a validation installed on an account MUST be unique.
The entityId of a validation function installed on an account MUST be unique.
Validation installation MAY be deferred until a later time, such as upon first use.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation installation MAY be deferred until a later time, such as upon first use.

Not sure if this is the place to put this callout. I know we haven't yet updated the section for the install / uninstall functions, but it seems like this should be mentioned there instead, like "these functions are not the only way to install a module, the account MAY define other functions for installing and uninstalling modules".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this section (#### Validations and their installation /uninstallation) is aiming for more general (un)installations callout like this.

"these functions are not the only way to install a module, the account MAY define other functions for installing and uninstalling modules".
Should we callout this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, it is just an overview. Approving to unblock.

@fangting-alchemy fangting-alchemy requested a review from a team August 27, 2024 20:39
@fangting-alchemy fangting-alchemy merged commit a748955 into develop Aug 27, 2024
@jaypaik jaypaik deleted the validation branch October 9, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants