refactor: rename UpgradeableModularAccount to ReferenceModularAccount #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
reviewed
Aug 22, 2024
howydev
approved these changes
Aug 22, 2024
Collaborator
howydev
left a comment
howydev
left a comment
There was a problem hiding this comment.
1 small fix otherwise LGTM
adamegyed
force-pushed
the
adam/rename-account
branch
2 times, most recently
from
7dcc4b7 to
9dbf09d
Compare
adamegyed
force-pushed
the
adam/rename-account
branch
from
9dbf09d to
858f035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The name
UpgradeableModularAccountis a relic from when 6900 shifted from diamond proxies to regular ERC-1967 proxies, and is no longer a distinguishing name.Solution
Rename UpgradeableModularAccount to ReferenceModularAccount.