Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/account/UpgradeableModularAccount.sol
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,10 @@ contract UpgradeableModularAccount is
return execReturnData;
}

/// @inheritdoc IAccountExecute
/// @notice Execution function that allows UO context to be passed to execution hooks
/// @dev This function is only callable by the EntryPoint
function executeUserOp(PackedUserOperation calldata userOp, bytes32) external {
function executeUserOp(PackedUserOperation calldata userOp, bytes32) external override {
if (msg.sender != address(_ENTRY_POINT)) {
revert NotEntryPoint();
}
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/IAccountLoupe.sol
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ interface IAccountLoupe {

/// @notice Get the validation data for a validation.
/// @dev If the selector is a native function, the module address will be the address of the account.
/// @param validationFunction The validationFunction to get the data for.
/// @param validationFunction The validation function to get the data for.
/// @return ValidationData The module address for this selector.
function getValidationData(ModuleEntity validationFunction)
external
Expand Down
8 changes: 2 additions & 6 deletions src/interfaces/IModuleManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,8 @@ interface IModuleManager {
bytes calldata moduleInstallData
) external;

/// @notice Temporary install function - pending a different user-supplied install config & manifest validation
/// path.
/// Installs a validation function across a set of execution selectors, and optionally mark it as a global
/// validation.
/// TODO: remove or update.
/// @notice Installs a validation function across a set of execution selectors, and optionally mark it as a
/// global validation.
/// @dev This does not validate anything against the manifest - the caller must ensure validity.
/// @param validationConfig The validation function to install, along with configuration flags.
/// @param selectors The selectors to install the validation function for.
Expand All @@ -46,7 +43,6 @@ interface IModuleManager {
) external;

/// @notice Uninstall a validation function from a set of execution selectors.
/// TODO: remove or update.
/// @param validationFunction The validation function to uninstall.
/// @param uninstallData Optional data to be decoded and used by the module to clear module data for the
/// account.
Expand Down
5 changes: 2 additions & 3 deletions src/interfaces/IStandardExecutor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@ interface IStandardExecutor {
/// @return An array containing the return data from the calls.
function executeBatch(Call[] calldata calls) external payable returns (bytes[] memory);

/// @notice Execute a call using a specified runtime validation, as given in the first 21 bytes of
/// `authorization`.
/// @notice Execute a call using a specified runtime validation.
/// @param data The calldata to send to the account.
/// @param authorization The authorization data to use for the call. The first 21 bytes specifies which runtime
/// @param authorization The authorization data to use for the call. The first 24 bytes specifies which runtime
/// validation to use, and the rest is sent as a parameter to runtime validation.
function executeWithAuthorization(bytes calldata data, bytes calldata authorization)
external
Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/IValidationModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {PackedUserOperation} from "@eth-infinitism/account-abstraction/interface
import {IModule} from "./IModule.sol";

interface IValidationModule is IModule {
/// @notice Run the user operation validationFunction specified by the `entityId`.
/// @notice Run the user operation validation function specified by the `entityId`.
/// @param entityId An identifier that routes the call to different internal implementations, should there
/// be more than one.
/// @param userOp The user operation.
Expand All @@ -16,7 +16,7 @@ interface IValidationModule is IModule {
external
returns (uint256);

/// @notice Run the runtime validationFunction specified by the `entityId`.
/// @notice Run the runtime validation function specified by the `entityId`.
/// @dev To indicate the entire call should revert, the function MUST revert.
/// @param account the account to validate for.
/// @param entityId An identifier that routes the call to different internal implementations, should there
Expand Down
Loading