feat: move account deploy event to factory #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For tracking deployed accounts of a specific type, it is preferable to emit the event from the factory, rather than the account address, because event signatures may be spoofed.
Solution
Remove the
ModularAccountInitializedevent fromUpgradeableModularAccount. The account already emitsValidationInstalled(module, entityId)andInitialized(version)during initialization.Add
ModularAccountDeployed(account, owner, salt)to the factory.We could also depend on the
AccountDeployedevent from the EntryPoint, but this has some issues: