feat(SingleSignerValidation): index additional event fields and mark anonymous [1/2] #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For retrieving previously set owners by validation ID, it would help to index the new signer. Additionally, since there's only one event type emitted by the SingleSignerValidation contract, we can mark the event as
anonymousand index the previous signer, rather than the event type.Solution
Update the
SignerTransferredevent to be anonymous, and index the previous and new signers.Update tests to check using the new event signature instead, specifically coming from the SingleSignerValidation module address.